fix(web): align file icon with text in Read/Edit tool rows - #231
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (98)
📝 WalkthroughWalkthroughThe PR centers file icons in Read and Edit tool rows, records a patch changeset, and regenerates web assets with updated dependencies and bundled diagram, editor, language, and Vue runtime modules. ChangesTool alignment and web bundle
Estimated code review effort: 3 (Moderate) | ~20 minutes ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Warning Some tools did not complete. Review the errors below. 🔧 ast-grep (0.45.2)apps/pythinker-code/dist-web/assets/cynefin-OW5HDTMX-bXF9dhPA.jsast-grep timed out on this file apps/pythinker-code/dist-web/.web-bundle-manifest.jsonast-grep did not scan this file: retry isolation stopped after a systemic timeout or after exhausting the retry isolation budget apps/pythinker-code/dist-web/assets/CodeBlockNode-DUUxKNHt.jsast-grep did not scan this file: retry isolation stopped after a systemic timeout or after exhausting the retry isolation budget
Comment |
commit: |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The file-type icon after the Read/Edit label sat above the text line.
.bh-textaligns children by baseline, and.tl-ficonhadline-height: 0, so its baseline collapsed to its bottom edge and the icon rode high. Droppedline-height: 0and addedalign-self: centerin ReadTool.vue / EditTool.vue; restageddist-web.Testing
pnpm run build:webSummary by CodeRabbit
Bug Fixes
Chores